Skip to content

Comments

fix(pfe-jump-links): aligning type to 1rem/16px#1866

Merged
bennypowers merged 1 commit intofeat/pfe-toolsfrom
2.0-jumplinks-type
Feb 3, 2022
Merged

fix(pfe-jump-links): aligning type to 1rem/16px#1866
bennypowers merged 1 commit intofeat/pfe-toolsfrom
2.0-jumplinks-type

Conversation

@Djfaucette
Copy link
Contributor

@Djfaucette Djfaucette commented Feb 2, 2022

Related issues

Preview

Link(s) to demo page(s) where this element can be viewed:

What has changed and why

Testing instructions

Browser requirements

Your component should work in all of the following environments:

  • Latest 2 versions of Edge
  • Internet Explorer 11 (should be useable, not pixel perfect)
  • Latest 2 versions of Firefox (one on Mac OS, one of Windows OS)
  • Firefox 78 (or latest version for Red Hat Enterprise Linux distribution)
  • Latest 2 versions of Chrome (one on Mac OS, one of Windows OS)
  • Latest 2 versions of Safari
  • Android mobile device (such as the Galaxy S9)
  • Apple mobile device (such as the iPhone X)
  • Apple tablet device (such as the iPhone Pro)

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one request or issue (no stragglers or scope-creep).
  • Tests have been updated to cover these changes.
  • Browser testing passed.
  • Changelog updated.
  • Documentation (README.md, WHY.md, etc.) updated or added.
  • Link to the demo recording:
  • Approved by designer.

Merging

Please squash when merging and ensure your commit message uses conventional commit formatting.

Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: eb490ae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the styles An issue or PR pertaining only to CSS/Sass label Feb 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

👕 Commitlint Problems for this PR:

🔎 found 2 errors, 0 warnings
ℹ️ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

bf4a504 - aligning type to 1rem/16px

  • ❌ subject may not be empty
  • ❌ type may not be empty

@github-actions github-actions bot added the AT passed Automated testing has passed label Feb 2, 2022
@bennypowers
Copy link
Member

bennypowers commented Feb 2, 2022

Thanks @Djfaucette LGTM

The linting errors are unrelated, and it appears the test failures are as well

@bennypowers
Copy link
Member

bennypowers commented Feb 2, 2022

To solve the conventional commit, we need a commit message that conforms to the style guide, e.g.

fix(jump-links): align styles with rh designs

There are two options to fix that problem

  1. reword the commit to conform to the commit style
  2. rename the PR to conform to commit style

@Djfaucette Djfaucette changed the title aligning type to 1rem/16px fix(pfe-jump-links): aligning type to 1rem/16px Feb 2, 2022
@bennypowers bennypowers force-pushed the feat/pfe-tools branch 6 times, most recently from 8342ea8 to 793519f Compare February 3, 2022 16:15
@Djfaucette @bennypowers
fix(jump-links): aligning styles to 1rem/16px
eb490ae 
Co-Authored-By: Daniel Faucette <dfaucett@redhat.com>
@bennypowers bennypowers merged commit 07bc55e into feat/pfe-tools Feb 3, 2022
@bennypowers bennypowers deleted the 2.0-jumplinks-type branch February 3, 2022 18:15
@bennypowers
Copy link
Member

bennypowers commented Feb 3, 2022

O YEAH

Many a thank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

AT passed Automated testing has passed styles An issue or PR pertaining only to CSS/Sass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Djfaucette @bennypowers